D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ConfigIcons.qml:130
>  
> -        // Row 1: Spacing
> -        Item {
> -            Layout.row: 1
> -            Layout.column: 0
> -            Layout.minimumHeight: units.largeSpacing
> +        Kirigami.Spacer {
>              visible: isPopup

those should be just

Item {
Kirigami.FormData.isSection: true
}

then, we'll see how things in formlayout have to be fixed to reach the desired spacing/result

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein, mart
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181022/7dce7560/attachment.html>