D15786: share common values for both Breeze and Breeze-dark GTK themes

[Olli Helin]

ohelin added a comment.


  In D15786#346959 <https://phabricator.kde.org/D15786#346959>, @ngraham wrote:
  
  > @grmat Thank you very much for this patch. I'm sorry that nobody has reviewed it yet. I think people are just intimidated by the huge diff lol. I will make an effort to do so, but it might help if you could produce a simplified diff showing just the actual substantive changes and post it in a comment here, in the manner that @ohelin did in D16331#346548 <https://phabricator.kde.org/D16331#346548>.
  >
  > Sadly this patch doesn't apply cleanly on git master for me:
  >
  >   error: patch failed: Breeze-dark-gtk/gtk-3.20/gtk.css:61
  >   Applying patch Breeze-gtk/gtk-3.20/gtk.css with 1 reject...
  >   Rejected hunk #1.
  >   Applied patch Breeze-gtk/gtk-3.20/common.css cleanly.
  >   Applying patch Breeze-dark-gtk/gtk-3.20/gtk.css with 1 reject...
  >   Rejected hunk #1.
  >  
  >    Patch Failed! 
  >   Usage Exception: Unable to apply patch!
  >
  >
  > Can you re-base it on current git master please? Thanks!
  
  
  I can do the special diffs, didn't just have time yet. I'll try to check out the conflicts also - it's probably that typo fix I did. Might be something else too.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D15786

To: grmat, jackg, #plasma
Cc: ngraham, ohelin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181021/0f645480/attachment-0001.html>