D16316: [Kicker] Rename id column to itemColumn

Kai Uwe Broulik noreply at phabricator.kde.org
Fri Oct 19 14:00:28 BST 2018


broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  In Qt 5.12 new magic `column` and `row` properties appeared in the delegate's scope, similar to the `index` and `model` (`modelData`) one.
  This causes `column` to access that (being always the number zero for this list model) and as such the delegate not having a width and turning invisible.

TEST PLAN
  So much for Qt versioning... quite a horrible behavior change as I typically also just call my Column `column`... let's work around this in 5.14 (or even 5.12 since it's quite trivial change) here and escalate to Qt then...
  
  - All apps and krunner in kickerdash work again

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16316

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemMultiGridView.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181019/15bc3619/attachment.html>


More information about the Plasma-devel mailing list