D16297: [DBusMenuImporter] Don't call removeAction() to avoid an empty QMenu

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, poboiko.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  As soon as `QMenu` becomes empty it is closed. This can happen when the application completely reloads its menu.
  Instead, call `deleteLater` which will destroy the `QAction` later at which point it is automatically removed from the menu.
  
  BUG: 399975

TEST PLAN
  A less invasive, albeit more questionable, patch than D15637 <https://phabricator.kde.org/D15637>
  Should this go in stable, or test it a bit more and then put it in stable?
  
  - Lyx menu behaves fine now (the title bar button is still somewhat borked by Lyx sends menu updates a gazillion times)
  - Krita menu behaves fine now
  - Thunderbird menu behaves fine now
  - systray stuff seems to work fine

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16297

AFFECTED FILES
  libdbusmenuqt/dbusmenuimporter.cpp

To: broulik, #plasma, davidedmundson, poboiko
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181018/5d76f106/attachment.html>