D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.


  Thanks for the contribution. I'll push this change and do just some minor changes to the tests so you don't have to again go through review.

INLINE COMMENTS

> CMakeLists.txt:99
>  add_subdirectory(vpn)
> +add_subdirectory(tests)
>  

Tests shouldn't be build automatically, you should add somethine like https://cgit.kde.org/networkmanager-qt.git/tree/CMakeLists.txt#n43.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15520

To: andersonbruce, jgrulich, pino
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181017/6c7569d3/attachment.html>