D16231: [ksmserver] Rewrite Startup

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The code is effectively 3 startup phases each of which has some parallel
  methods that need to be complete before moving onto the next phase.
  
  The old code had a tonne of methods all of which tracking what state
  we're in and trying to start the next method in the chain handling
  things out of order.
  
  This simplifies everything into 3 composite kjobs. A lot more classes,
  but each one tiny with the flow more readable.
  
  Code should be effectively the same. The startup sound is moved ever so
  slightly earlier to be when phase 2 starts rather than just after
  kcminit2 finishes (midway through the old phase 2), but no significant
  behavioural changes here.

TEST PLAN
  Logged in with session restore and without

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16231

AFFECTED FILES
  ksmserver/server.h
  ksmserver/startup.cpp
  ksmserver/startup.h

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181015/58396718/attachment.html>