D16225: [ksmserver] Split startup into separate class

David Edmundson noreply at phabricator.kde.org
Mon Oct 15 14:56:49 BST 2018


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Everything related to Plasma startup goes in Startup everything relating
  to X session management stays in KSMServer.  Restoring the window
  manager currently stays inside ksmserver as it passes the session ID as
  an argument and at various points checks if something the client is the
  WM.
  Relevant methods move to server.cpp to keep one class per cpp file.
  
  KSMServer gains some signals as it can no longer call the startup methods
  directly to continue the process.
  
  This is part of a cleanup series in ksmserver. (The friend class will disappear
  in the next commit)
  
  Behaviour should remain identical.

TEST PLAN
  Logged in on X

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16225

AFFECTED FILES
  ksmserver/main.cpp
  ksmserver/server.cpp
  ksmserver/server.h
  ksmserver/startup.cpp
  ksmserver/startup.h

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181015/b8ea0a84/attachment.html>


More information about the Plasma-devel mailing list