D15616: [Comic] Handle error state correctly

[Anthony Fieroni]

anthonyfieroni added a comment.


  In D15616#341840 <https://phabricator.kde.org/D15616#341840>, @davidedmundson wrote:
  
  > The DataEngine also has a timer for timeouts, so we now have two timeout timers. 
  >  Having two timeout timers doesn't seem right.
  
  
  Yep, i'm on same opinion, it looks like i some cases timer in DataEngine is not started. One possible case what i provide in ComicProvider::requestRedirectedUrl, i don't see other cases where dataUpdated isn't called. mRestartEngine timer is in "any case".

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D15616

To: anthonyfieroni, davidedmundson, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181012/3438ff86/attachment.html>