D16042: [ksmserver] remove unused suspend/resume startup API

David Edmundson noreply at phabricator.kde.org
Mon Oct 8 11:03:12 BST 2018


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  ksmserver autostart had a system where processes, such as plasma, could
  block the startup phase from moving on.
  
  It is currently entirely unused.
  
  It's very difficult to use properly, plasmashell has to block startup
  before ksmserver moves on to phase 1. Racey at best.
  
  I did hack it to work, and it does make a surprising positive
  improvement to bootup. Worth exploring the idea properly, but implemented
  better.
  
  We should be able to get the same results by
  blocking and waiting for the DBus name in the autostart desktop file to
  become registered rather than having a ksmserver-specific solution.

TEST PLAN
  Compiles, can still login

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16042

AFFECTED FILES
  ksmserver/org.kde.KSMServerInterface.xml
  ksmserver/server.cpp
  ksmserver/server.h
  ksmserver/startup.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181008/eb6db0da/attachment.html>


More information about the Plasma-devel mailing list