D16014: Give ActionButton an optional and off-by-default drop shadow

Nathaniel Graham noreply at phabricator.kde.org
Sun Oct 7 15:05:15 BST 2018


ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  `ActionButton`'s text can be difficult to see when the background is light-colored or very busy.
  
  For clients that may put an `ActionButton` on top of such a background, this patch allows the client to add a drop shadow to the text to improve contrast and reabability. It is off by default.

TEST PLAN
  No visual change for any current clients (login screen, lock screen, logout screen)
  
  Here is what it would look like if enabled:
  [image goes here]

REPOSITORY
  R120 Plasma Workspace

BRANCH
  actionbutton-optional-label-shadow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16014

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml

To: ngraham, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181007/6d38bb80/attachment.html>


More information about the Plasma-devel mailing list