D15907: Compare float values in DecorationButton contains check

[Vlad Zagorodniy]

zzag added a comment.


  Also, fwiw, comparing floating point numbers with the plain `<` is not quite correct(e.g. 0.3 < 0.1 + 0.2 vs 0.1 + 0.2 < 0.3). Qt does the same so I guess that's fine.

INLINE COMMENTS

> decorationbutton.cpp:455
> +    // additional make sure pos is not on the right or bottom edge
> +    const bool verInside = d->geometry.width() < 0 ? pos.x() < d->geometry.x() :
> +                                                     pos.x() < d->geometry.right();

Can you please explain this part? Shouldn't it be `d->geometry.right() < pos.x()`?

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D15907

To: romangg, #kwin, zzag, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181002/d8dbaba6/attachment-0001.html>