D15840: [Folder View] Remember selected item when navigating in subfolders
Thomas Surrel
noreply at phabricator.kde.org
Mon Oct 1 14:04:22 BST 2018
thsurrel added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in FolderView.qml:1114
> Do we have grodView.model after back clicked? If we do in expanded view (that's when Folder View is embedded in the panel) goingBack will not be performed.
My understanding was that the gridView.model could be undefined only if the FolderModel was not ready. But if we navigated into a subfolder and we are asking to go back, than the FolderModel had to be up and running already. Could be safe to move this 'if' outside the 'else' though.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D15840
To: thsurrel, #plasma, broulik, hein
Cc: anthonyfieroni, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181001/a9db7491/attachment-0001.html>
More information about the Plasma-devel
mailing list