D15869: Fallback to in-process prompt if logout prompt fails

David Edmundson noreply at phabricator.kde.org
Mon Oct 1 12:04:33 BST 2018


davidedmundson added a comment.


  It was.The situation is now much much much better.
  But kscreenlocker-greet is a different process, and we've definitely seen that fallback prompt shown.
  
  Also I don't like the way it was done. It was done as a conservative exact 1:1 mapping of the original code with a FD in the middle rather than designing something.
  
  All that was needed was:
  
  - spawn logout prompt (probably DBus activation to avoid dupes) as fire-and-forget
  - logout prompt using the existing ksmserver API to perform logout/shutdown over DBus with the "don't confirm" argument set
  
  In my quest to strip ksmserver to being just an X session manager, I want to do the refactor above so that it's then highly movable.
  
  I think I can do everything in a backwards compatible way for each release, I'm not sure about doing every possible upgrade combo.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15869

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181001/0ac1fe31/attachment.html>


More information about the Plasma-devel mailing list