D15870: Move kactivitymanagerd to libexec and remove manual daemon management

David Edmundson noreply at phabricator.kde.org
Mon Oct 1 09:49:36 BST 2018


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Since it was made DBus activatable having any other code to start/stop
  the daemon doesn't really make any sense. For that reason I've
  moved it to libexec.
  
  Also the original code is somewhat questionable. It creates a whole qapp
  instance, checks if we're registered then forks itself to spawn a new
  version of the app that then registers.
  
  KDBusService already does all this in a simpler faster non-racey way.

TEST PLAN
  Installed
  Still got kactivitymanagerd

REPOSITORY
  R161 KActivity Manager Service

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15870

AFFECTED FILES
  src/CMakeLists.txt
  src/kactivities-features.h.cmake
  src/org.kde.activitymanager.service.in
  src/service/Application.cpp
  src/service/CMakeLists.txt

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181001/11391de5/attachment.html>


More information about the Plasma-devel mailing list