D17233: Only cancel job when an "error" is set and ignore "interrupted"

[Fabian Vogt]

fvogt added a comment.


  LGTM otherwise.

INLINE COMMENTS

> downloadjob.cpp:152
> +        const QString error = it->toString();
> +        if (!error.isEmpty()) {
>              if (error == QLatin1String("USER_CANCELED")

You could change this into

  QString error = payload.value(QStringLiteral("error")).toString();
  if(!error.isEmpty())

> downloadjob.cpp:207
> +
> +    it = payload.constFind(QStringLiteral("state"));
> +    if (it != end) {

Same here as for error above.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D17233

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181130/1cbb5da2/attachment-0001.html>