D17233: Delay finishing download when state changes to "interrupted"

[Fabian Vogt]

fvogt added a comment.


  It might work as well to just ignore the "interrupted" `state` completely and only react when `error` becomes set.
  
  The docs say that error is undefined if no error occured (It's actually `null` here, so it's already a doc violation...), so if it's set that's a better trigger to terminate the KJob AFAICT.
  
  The way I tested it here (a php script with a sleep inside) the download doesn't actually terminate until the sleep runs out, so I got the "unknown error" message anyway.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D17233

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181129/4aa840cf/attachment.html>