D17212: Port to QQC2 and FormLayout

Marco Martin noreply at phabricator.kde.org
Thu Nov 29 16:02:43 GMT 2018


mart added a comment.


  In D17212#368135 <https://phabricator.kde.org/D17212#368135>, @abetts wrote:
  
  > In D17212#368048 <https://phabricator.kde.org/D17212#368048>, @mart wrote:
  >
  > > F6446445: Screenshot_20181129_143041.png <https://phabricator.kde.org/F6446445>
  >
  >
  > Wait! Isn't the header labels supposed to be on the right? They are also supposed to be aligned to the first item in the series of checkboxes.
  
  
  no
  
  > Current:
  > 
  > LABEL
  > 
  > [X] ITEM
  > 
  >   Proper:
  > 
  >   LABEL [x] ITEM
  
  no, formalyout titles are titles on top of the section.
  They used to always be left aligned, but after a long discussion they were moved towards the center as well.
  This is the reference implementation of a correct form layout in the kirigami gallery:
  
  F6447089: Screenshot_20181129_170219.png <https://phabricator.kde.org/F6447089>

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/qqc2

REVISION DETAIL
  https://phabricator.kde.org/D17212

To: mart, #plasma, #vdg, ngraham
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181129/3eaa6879/attachment.html>


More information about the Plasma-devel mailing list