D4929: DrKonqi : lldb and Mac support
René J.V. Bertin
noreply at phabricator.kde.org
Tue Nov 27 11:59:37 GMT 2018
rjvbb updated this revision to Diff 46309.
rjvbb marked 2 inline comments as done.
rjvbb added a comment.
Fixed the AppleTerminal oversight in the non-Apple lldbrc.
Also, I've removed the m_lldbDetached backend-specific member var. Instead, I now use the `m_proc` variable itself, and which will be nulled when we simulate the debugger exit.
Or when the debugger actuall exits when we ask it to. Sometimes it does, which is why m_proc is tested before being used when detach output has been detected.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4929?vs=46044&id=46309
REVISION DETAIL
https://phabricator.kde.org/D4929
AFFECTED FILES
CMakeLists.txt
src/CMakeLists.txt
src/backtracegenerator.cpp
src/backtracewidget.cpp
src/data/debuggers/external.mac/lldbrc
src/data/debuggers/external/lldbrc
src/data/debuggers/internal/lldbrc
src/debugger.cpp
src/debugger.h
src/drkonqibackends.cpp
src/main.cpp
src/parser/CMakeLists.txt
src/parser/backtraceparser.cpp
src/parser/backtraceparserlldb.cpp
src/parser/backtraceparserlldb.h
src/tests/CMakeLists.txt
To: rjvbb, #plasma_workspaces, kfunk, davidedmundson
Cc: plasma-devel, #kde_applications, patrickelectric, kfunk, mart, broulik, kde-mac, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181127/bd56582d/attachment.html>
More information about the Plasma-devel
mailing list