D17181: [Componentchooser KCM] Make default browser app choice work even when combobox is not used

Nathaniel Graham noreply at phabricator.kde.org
Tue Nov 27 00:38:19 GMT 2018


ngraham added inline comments.

INLINE COMMENTS

> davidedmundson wrote in componentchooserbrowser.cpp:49
> this "emit" looks wrong

What should it be instead? That line is just copy-pasted from the original inline function.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-default-browser-app-combobox (branched from Plasma/5.12)

REVISION DETAIL
  https://phabricator.kde.org/D17181

To: ngraham, #plasma, cfeck, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181127/f5547662/attachment-0001.html>


More information about the Plasma-devel mailing list