D16996: Add method to write retention to configuration control files

Marco Martin noreply at phabricator.kde.org
Fri Nov 23 11:49:59 GMT 2018


mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> control.cpp:163
> +    }
> +    file.write(QJsonDocument::fromVariant(m_info).toJson());
> +//    qCDebug(KSCREEN_COMMON) << "Config control saved on: " << file.fileName();

maybe check if it's actually a valid json document?, even just !document.isEmpty() after creating the document

REPOSITORY
  R104 KScreen

BRANCH
  0controlWrite

REVISION DETAIL
  https://phabricator.kde.org/D16996

To: romangg, #plasma, mart
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181123/07d69df9/attachment.html>


More information about the Plasma-devel mailing list