D17025: Perf: Do expensive regexp construction earlier

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Nov 20 01:17:57 GMT 2018


apol added inline comments.

INLINE COMMENTS

> systemtray.cpp:88
>              qCDebug(SYSTEM_TRAY) << "ST Found DBus-able Applet: " << info.pluginId() << dbusactivation;
> -            m_dbusActivatableTasks[info.pluginId()] = dbusactivation;
> +            QRegExp rx(dbusactivation);
> +            rx.setPatternSyntax(QRegExp::Wildcard);

Shouldn't we prefer QRegularExpression?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17025

To: kfunk, davidedmundson
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181120/c3470ede/attachment.html>


More information about the Plasma-devel mailing list