D17025: Perf: Do expensive regexp construction earlier

Kevin Funk noreply at phabricator.kde.org
Mon Nov 19 20:32:08 GMT 2018


kfunk created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kfunk requested review of this revision.

REVISION SUMMARY
  SystemTray::serviceRegistered is called tons of times; the regexp
  construction inside the for-loop is expensive and should be avoided.
  Thus construct the regexp once, and re-use the regexp object each time.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17025

AFFECTED FILES
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h

To: kfunk
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181119/75f7b753/attachment.html>


More information about the Plasma-devel mailing list