D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)
Root
noreply at phabricator.kde.org
Sun Nov 18 14:15:11 GMT 2018
rooty added a comment.
In D16937#361224 <https://phabricator.kde.org/D16937#361224>, @romangg wrote:
> Would someone take a look at the Simple Menu code to see if the unfocused search field code can be copied over directly to Kickoff (separate review though)?
Long story short, no. It can't but I managed to splice together my own Header.qml using the older (no search field) and current master Header.qml:
F6430546: image.png <https://phabricator.kde.org/F6430546>
Should I open up a new differential @romangg? Does this look acceptable?
Two problems though:
(1) Should it be left as "Type to search..." (so the user knows they can, in fact, **type** to search) or should it just be "Search..."
(2) There's a bug I haven't rooted out yet (no pun intended) that pops up when you open it up and press the tab key, it starts typing right after/next to //Type to search...//
But other than that it seems to work fine.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D16937
To: rooty, ngraham, #vdg
Cc: romangg, filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181118/e59db786/attachment.html>
More information about the Plasma-devel
mailing list