D16918: [brightnesscontrol] Do not change screen brightness on invalid values

Anthony Fieroni noreply at phabricator.kde.org
Fri Nov 16 08:42:19 GMT 2018


anthonyfieroni created this revision.
anthonyfieroni added reviewers: Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
anthonyfieroni requested review of this revision.

REVISION SUMMARY
  The problem:
  
  1. Unplug laptop power supply
  2. On screen energy saving in settings
  3. Uncheck screen brightness (on all profiles or on that will be loaded)
  4. Wait minutes display to do off (not dimmed)
  5. Plug power supply without display on
  6. When it's on, screen brightness is 100%
  
  Probably it's depends of backend (intel in my case) on dpms it returns *garbage* values even on max brightness (it's still not tested)
  
  The solution:
  Trying to cache max brightness level and denied to change screen brightness on garbage values

TEST PLAN
  @broulik if you have better solution, i'll test it

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16918

AFFECTED FILES
  daemon/actions/bundled/brightnesscontrol.cpp
  daemon/actions/bundled/brightnesscontrol.h

To: anthonyfieroni, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181116/86d5f7ef/attachment.html>


More information about the Plasma-devel mailing list