D16888: Recreate interrupted download when it is resumed

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Nov 15 02:09:45 GMT 2018


broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When a download is canceled, finishes, or is interrupted (e.g. loss of network connection) we finish the `KJob` to remove it from notification area.
  However, when a job was interrupted and is then resumed, the download ID is reused by the browser and we only get sent updates for a job we no longer have.
  When we get a change event from `interrupted` to `in_progress` just pretend a new download was created and carry on as normal.
  
  BUG: 401038

TEST PLAN
  - Started a download, cut my network, waited for it to fail, resumed it: now got a download job in notification area, previously nothing would happen
  - Canceling and restarting the download still works fine
  - Starting a new download still works fine

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D16888

AFFECTED FILES
  extension/extension.js

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181115/0994d4ce/attachment.html>


More information about the Plasma-devel mailing list