D16875: [kded] Cleanup KScreenDaemon class

Roman Gilg noreply at phabricator.kde.org
Wed Nov 14 16:42:34 GMT 2018


romangg added inline comments.

INLINE COMMENTS

> davidedmundson wrote in daemon.h:47
> this has moved from being a slot.
> 
> If it is invoked from DBus as the comment suggests that will be a problem

Are you sure this is a problem? I just tested it manually with qdbusviewer and the method was called accordingly.

Nowadays in Qt can't every function act as a slot, even without the Q_SLOTS specifier?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D16875

To: romangg, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181114/e1e6ed27/attachment.html>


More information about the Plasma-devel mailing list