D16805: improve variable name for global menu model

Michail Vourlakos noreply at phabricator.kde.org
Sat Nov 10 14:53:40 GMT 2018


mvourlakos created this revision.
mvourlakos added reviewers: Plasma, broulik, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  --the currentWindowId variable is currently used
  only for windows that are delaying their global
  menus creation. This patch improves its naming
  in order to be able to use the m_currentWindowId
  variable in the future for what the name says,
  the window id of the current window
  independent of its use.

TEST PLAN
  --Test that global menu still works correctly

REPOSITORY
  R120 Plasma Workspace

BRANCH
  appMenuDelayed

REVISION DETAIL
  https://phabricator.kde.org/D16805

AFFECTED FILES
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181110/2e16e4ee/attachment.html>


More information about the Plasma-devel mailing list