D16776: Better error handling in KNewStuff backend

[Aleix Pol Gonzalez]

apol added a comment.


  Where will the `All categories are missing` error fall right now?

INLINE COMMENTS

> KNSBackend.cpp:247
> +    QString error = message;
> +    bool invalidFile = false;
> +    switch(errorCode) {

Maybe at least qDebug() it?

> KNSBackend.cpp:275
> +        case KNSCore::ErrorCode::ProviderError:
> +            markInvalid(error);
> +            error = i18n("Invalid %1 backend, contact your distributor.", m_displayName);

Are you setting error after passing error? This reads weird. If you want to pass an empty one use `markInvalid({})`.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D16776

To: leinir, #discover_software_store, apol
Cc: plasma-devel, masilva, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181109/d0f2ff34/attachment.html>