D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

David Edmundson noreply at phabricator.kde.org
Fri Nov 9 01:08:22 GMT 2018


davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Why are there hardcoded colours?  If the font is black then surely the outline needs to be white?
  
  There's two parts to this patch:
  
  - Improving readability on any background, blurred or not, on login/lock/logout.
  
  - Changing the login visually
  
  The first part is non-controversial. They're iterative design changes. If you split it, I'll happily ship the 1st part (with hardcoded colours fixed)

INLINE COMMENTS

> Main.qml:322
> +        }
> +        height: units.gridUnit * 2
> +

This is now choosing an arbitrary size and hoping the contents happen to be smaller.

Generally (if possible) you want views to fit contents, not squish contents to view.

i.e

height: theInnerLayout.implicitHeight

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: romangg, davidedmundson, rizzitello, abetts, pstefan, broulik, rikmills, filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181109/46adfddb/attachment.html>


More information about the Plasma-devel mailing list