D16659: Size according to specified icon width and height

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Nov 5 00:22:32 GMT 2018


apol added a comment.


  +1 overall

INLINE COMMENTS

> kquickstyleitem.cpp:193
>          }
> +        int iconWidth = m_properties[QStringLiteral("iconWidth")].toInt();
> +        int iconHeight = m_properties[QStringLiteral("iconHeight")].toInt();

Can we be a bit smarter here? If the size is present maybe we wouldn't have to check the pixelMetric.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16659

To: astippich, #plasma, mart, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181105/89fbc8c9/attachment.html>


More information about the Plasma-devel mailing list