D16587: [ksmserver] Simplify call to kcminit

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  kcminit had a slot to start processing something and a signal to emit
  when it's finished.
  
  For DBus that's quite bad practice as it can leave you hanging in the
  case of a kcminit crashing. It's better to use the return of the
  original call to signal when something is done.
  
  From ksmserver we can then just use DBus timeouts set on the interface
  than a secondary timer.
  
  We also remove a pointless blocking call to kcminit introspecting
  everything, if kcminit is not running it will return with an error
  immediately which is no slower than checking first if it's not running
  and faster if it is.

TEST PLAN
  Logged in
  Session logs showed kcminit ran

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16587

AFFECTED FILES
  ksmserver/startup.cpp
  ksmserver/startup.h
  startkde/kcminit/main.cpp
  startkde/kcminit/main.h

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181101/23768caa/attachment.html>