D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

[Kai Uwe Broulik]

broulik added a comment.


  Minor code nitpicks.
  
  Tab instant switch makes it feel a lot more responsive but I occasionally managed to accidentally activate the "Apps" tab when opening and moving, not sure how much that could happen in "normal use", though. +1 anyway

INLINE COMMENTS

> FullRepresentation.qml:402
> +
> +        property var oldPos: null
> +

`property point` or is that on purpose so you can set it to `null` instead to avoid ambiguity with e.g. `-1,-1`?

> FullRepresentation.qml:434
> +
> +            var dx  = (mouse.x - oldPos.x);
> +            var dy  = (mouse.y - oldPos.y);

Coding style, one space before `=`

> FullRepresentation.qml:493
> +                        return;
> +                    } else {
> +                        clickTimer.pendingButton = button;

No `else` since you `return` in the `if` branch

  if (...) {
      ...
      return;
  }
  
  ...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13192

To: hein, ngraham, davidedmundson, rkflx, cfeck
Cc: broulik, mart, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180530/3d1f8f79/attachment.html>