D13202: Circular user avatar for Kickoff

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> Header.qml:76
> +        
> +       OpacityMask {
> +           anchors.fill: squareFace

needed?

> Header.qml:102
> +                hideSource: true
> +                live: false
> +            }

because this is false, we need to force an update every time      squareFace changes

> Header.qml:113
> +
> +            //if copying into another project don't forget to connect themeChanged to update()
> +            //but in SDDM that's a bit pointless

and when the theme changes

> Header.qml:121
> +                            uniform lowp vec4 colorBorder;
> +                            highp float blend = 0.01;
> +                            highp float innerRadius = 0.46;

decreasing the border width but increasing this might make it more rounded

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13202

To: sharvey, ngraham, hein, #plasma
Cc: davidedmundson, plasma-devel, abetts, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180529/5e4ec4ea/attachment.html>