D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

Eike Hein noreply at phabricator.kde.org
Tue May 29 11:50:25 UTC 2018


hein created this revision.
hein added reviewers: ngraham, davidedmundson, rkflx, cfeck.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  D11848 <https://phabricator.kde.org/D11848> started out with the aim to remove the delay on Kickoff tab
  switching, but this proved contentious because it can cause user
  frustration over accidental tab switching when moving from the tab
  bar to the list view at angle, grazing another tab.
  
  This patch implements a triangle filter to get the best of both
  worlds. When the mouse motion vector is within the triangle from
  the vector starting coordinate pair to the relevant tab bar
  corners, the original 250ms delay remains in use. When the vector
  is outside the triangle, tabs are switched immediately - improving
  even over the 50ms delay proposed in D11848 <https://phabricator.kde.org/D11848>.
  
  Care is taken so that tab switching is always immediate when the
  tab bar is freshly entered, e.g. moving from the panel to Kickoff.
  
  As a small advantage this removes a MouseArea item from each tab
  button.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13192

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml
  applets/kickoff/package/contents/ui/KickoffButton.qml

To: hein, ngraham, davidedmundson, rkflx, cfeck
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180529/432e3675/attachment.html>


More information about the Plasma-devel mailing list