D13183: Use Control.palette

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue May 29 10:49:03 UTC 2018


apol added a comment.


  In D13183#270156 <https://phabricator.kde.org/D13183#270156>, @mart wrote:
  
  > to not break all custom kirigami color set, i think by default all controls in the desktop style should be binded to Kirigami.Theme.palette
  >  or the colorset, complementary areas gets broken
  
  
  Do you want patches like this on every component?
  
    diff --git a/org.kde.desktop/Button.qml b/org.kde.desktop/Button.qml
    index 08a8f0e..2efbf9a 100644
    --- a/org.kde.desktop/Button.qml
    +++ b/org.kde.desktop/Button.qml
    @@ -34,6 +34,8 @@ T.Button {
     
         hoverEnabled: true //Qt.styleHints.useHoverEffects TODO: how to make this work in 5.7?
     
    +    palette: Kirigami.Theme.palette
    +
         contentItem: Item {}
         Kirigami.MnemonicData.enabled: controlRoot.enabled && controlRoot.visible
         Kirigami.MnemonicData.controlType: Kirigami.MnemonicData.ActionElement

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D13183

To: apol, #kirigami, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180529/df671c0b/attachment.html>


More information about the Plasma-devel mailing list