D12937: Drop privileges when reading the salt file

Albert Astals Cid noreply at phabricator.kde.org
Sun May 27 19:46:23 UTC 2018


aacid added inline comments.

INLINE COMMENTS

> dakon wrote in pam_kwallet.c:750
> There can't happen anything too bad here I guess, the read() will just fail or crash.
> 
> I wonder if we should not get rid of this alltogether and just pass in a stack buffer from the caller, this would avoid any failures and leaks on it.

It's a different process, that's why we're using pipes, i don't really want to go into shared process memory for something as simple as this.

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D12937

To: aacid, dakon
Cc: dakon, mgerstner, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180527/74646b01/attachment.html>


More information about the Plasma-devel mailing list