D12937: Drop privileges when reading the salt file

Albert Astals Cid noreply at phabricator.kde.org
Sun May 27 15:35:55 UTC 2018


aacid added inline comments.

INLINE COMMENTS

> dakon wrote in pam_kwallet.c:750
> I don't see a benefit in introducing new bugs just to keep a style. And if the code does it right at some places this one should also just start right.

it's not a bug

the code works and will work 100% of times, pretending malloc fails is nice from a teoretical point of view, but it's not going to happen, if you're going to block me on this i will make you happy, but you should know you're wasting my and your time for no reason.

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D12937

To: aacid, dakon
Cc: dakon, mgerstner, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180527/b1a60bf9/attachment-0001.html>


More information about the Plasma-devel mailing list