D12937: Drop privileges when reading the salt file
Albert Astals Cid
noreply at phabricator.kde.org
Sun May 27 09:40:18 UTC 2018
aacid added inline comments.
INLINE COMMENTS
> dakon wrote in pam_kwallet.c:749
> please use WIFEXITED and WEXITSTATUS here. The compiler is free to optimize that into a simple compare if that's what it is, but you are now relying on an implementation detail of that status code.
we're assuming status 0 and != 0 in other places of the code, i'll suggest to also fix this separately in a new patch
REPOSITORY
R107 KWallet PAM Integration
REVISION DETAIL
https://phabricator.kde.org/D12937
To: aacid, dakon
Cc: dakon, mgerstner, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180527/75941f6d/attachment.html>
More information about the Plasma-devel
mailing list