D13112: first round of porting to QJSEngine

Marco Martin noreply at phabricator.kde.org
Fri May 25 13:38:52 UTC 2018


mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  nothing builds yet, unfortunately it needs a complete port
  in order to even build
  
  port of scriptengine::v1
  
  make ShellCorona build
  
  port containment, make it build
  
  remove i18n
  
  use KLocalizedContext now
  
  attempt for updated rect wrapper
  
  this would be pretty much useless anyways, but we need 100% api compatibility
  
  make scriptengine build
  
  make scriptengine_v1 build
  
  fully build
  
  a temporary, semi broken print()
  
  workaround for Appinterface: enclose in with(__AppInterface) {
  
  workaround for not being able to set our own global object and
  qproperties from prototype being broken
  
  make the Panel ctor work
  
  remove unused functions
  
  make the ConfigGroup ctor work
  
  reintroduce wrap()
  
  a bit less type safety to make things coming from readConfig work
  
  register functions as constructors
  
  ConfigGroup,QRect and Panel classes way less hacky
  
  make loadSerializedLayout actually work
  
  use a js based proxy for __proto__
  
  withthis we can dinamically read proeprties of __AppInterface
  as they were global
  
  nd a pure js object as QRectF
  
  this way is possible to retain 100% of the api that was added
  to QRectF by the previous script implementation
  
  get rid of the old backportglobal
  
  correctly wrap applet and containment

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mart/QJSEngineScripting

REVISION DETAIL
  https://phabricator.kde.org/D13112

AFFECTED FILES
  shell/CMakeLists.txt
  shell/scripting/appinterface.cpp
  shell/scripting/appinterface.h
  shell/scripting/backportglobal.h
  shell/scripting/configgroup.cpp
  shell/scripting/containment.cpp
  shell/scripting/containment.h
  shell/scripting/i18n.cpp
  shell/scripting/i18n.h
  shell/scripting/panel.cpp
  shell/scripting/panel.h
  shell/scripting/rect.cpp
  shell/scripting/scriptengine.cpp
  shell/scripting/scriptengine.h
  shell/scripting/scriptengine_v1.cpp
  shell/scripting/scriptengine_v1.h
  shell/scripting/widget.cpp
  shell/scripting/widget.h
  shell/shellcorona.cpp

To: mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180525/65868ea6/attachment.html>


More information about the Plasma-devel mailing list