D13101: Fix adding langs more than once within the same session.

Eike Hein noreply at phabricator.kde.org
Thu May 24 20:33:35 UTC 2018


hein added a comment.


  There's no more risk than before. Both versions of the code add two lists together, the other one just ran into Qt Quick type bullshit where one list got serialized to a string.
  
  In terms of what the risk of dupes is: There's one base model with a data role for "is this selected or not" and two filter models which filter this base model based on this data role, in opposite ways. The list in the add dialog is therefore guaranteed not to contain anything that's already selected.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13101

To: hein, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180524/46029c2b/attachment.html>


More information about the Plasma-devel mailing list