D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

[Nathaniel Graham]

ngraham added a comment.


  I don't object to your proposal per se, but I don't think it goes far enough to address the need here. Let me give you a specific example I'm familiar with:
  
  I recently submitted a patch (https://phabricator.kde.org/D13026) to fix a functional problem with Kate's Schema toolbar menu button (https://bugs.kde.org/show_bug.cgi?id=353747). Because of the bug that Hugo's patch here fixes, my Kate patch has the effect of removing the downward-pointing arrow, so the Schema button in Kate's toolbar will just be a single word, with no icon, and no downward-pointing arrow. It'll be just a piece of text awkwardly sitting there in the toolbar. In other words, without Hugo's patch here, fixing the functional problem (inappropriate requirement to click-and-hold) will cause a visual regression (the existing downward-pointing arrow disappears).
  
  We can of course later give the Schema an icon that you or someone else creates, but that's work for you (or Andreas, or someone else), and work for someone else to patch Kate to use the icon. Multiply this by the number of toolbar buttons affected by the issue throughout KDE software. We're talking about potentially a lot of icon design tasks and patches for apps to use them. And this burdens 3rd-party icon themes by increasing the number of icons they need to provide that will only be useful for users of the Breeze widget theme. And then what happens for people who use Breeze Icons or a compliant icon theme with a different widget theme that //does// draw downward-pointing arrows for menu buttons in toolbars? You'll have two downward-pointing arrows. Seems messy.
  
  Compare that complication and workload to just accepting this patch, which gives them all downward-pointing arrows in Breeze and resolves the issue without any icon design work or patches for individual apps or conflicts with other themes or extra work for 3rd-party icon themes. So to me it makes the most sense to handle this here in the theme rather than with an icon.
  
  If the objection to the arrow is that it's ugly, maybe we could come up with a prettier one?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D13064

To: hpereiradacosta, ngraham, abetts
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180523/aa88155e/attachment-0001.html>