D13069: [Task Manager] Fix URL comparison

Kai Uwe Broulik noreply at phabricator.kde.org
Wed May 23 16:36:30 UTC 2018


broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  You cannot compare to `null` but to empty string.
  This was done to disable "Pin" when no launcher URL is available but not properly executed in "Start New Instance"

TEST PLAN
  5.12 branch
  
  - "Launch new instance" is now disabled for e.g. wine notepad where it wouldn't work anyway (second change)
  - "Pin" is still properly checked depending on whether the task is pinned or not (first change)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13069

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180523/294e94dd/attachment.html>


More information about the Plasma-devel mailing list