D13054: SwipeItem: Fix using QRC resources and custom image providers.
Emmanuel Lepage Vallee
noreply at phabricator.kde.org
Wed May 23 07:34:45 UTC 2018
lepagevalleeemmanuel created this revision.
lepagevalleeemmanuel added a reviewer: mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
lepagevalleeemmanuel requested review of this revision.
REVISION SUMMARY
This patch does 2 things.
1. Check for the iconSource as defined in Action.qml
2. Mitigate the misuse of QUrl in desktopicon.cpp
Note that this isn't 100% correct. Imageprovider strings are not really URL, they are URI, it can be anything and include URI arguments. I think the proper solution would be to check exactly what QML does when ocnversion `image://` into identifier and do exactly that. Right now a string that works in `Image{}` and was valid per the image provider doc was modified by QUrl into something else.
TEST PLAN
Manual testing
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D13054
AFFECTED FILES
src/controls/templates/SwipeListItem.qml
src/desktopicon.cpp
To: lepagevalleeemmanuel, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180523/a4097d47/attachment.html>
More information about the Plasma-devel
mailing list