D13051: Fix Font KCM force font DPI checkbox

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Fixes numerous issues:
  
  1. the default behaviour had changed. It should disable force font DPI,
  
  not set it to 96
  
  2. disabling didn't work, we'd set the value to 0, which would update
  
  the spinbox, which has a minimum which sets the value to 96 (we were
  warned of this with a binding loop error)
  
  3. toggling the checkbox didn't enable the apply button
  
  New code fixes that and is more declarative too.
  
  BUG: 394180

TEST PLAN
  Toggled, reset to defaults, restarted

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13051

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/package/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180523/af65d77a/attachment.html>