D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Maximiliano Curia]

maximilianocuria added inline comments.

INLINE COMMENTS

> queryptrace.cpp:26
> +    server.sun_family = AF_UNIX;
> +    sprintf(server.sun_path, "/tmp/kcrash_%lld", QCoreApplication::applicationPid());
> +    if (::connect(sfd, (struct sockaddr *)&server, sl) == 0) {

Please honour TMPDIR or, even better, use QTemporaryDir (this will also make the generated path unpredictable), and create the socket inside.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks
Cc: maximilianocuria, adridg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180522/f977fde4/attachment-0001.html>