D13030: Always display brightness OSD even when at maximum
Kai Uwe Broulik
noreply at phabricator.kde.org
Tue May 22 07:27:24 UTC 2018
broulik added inline comments.
INLINE COMMENTS
> powerdevilupowerbackend.cpp:406
>
> - setBrightness(newBrightness, controlType);
> + if (newBrightness != currentBrightness) {
> + setBrightness(newBrightness, controlType);
Can we be sure that the `currentBrightness` is always up-to-date? We must still be able to force a new brightness if the hardware forgot to tell us or changed it outside our realm of influence
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D13030
To: thsurrel
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180522/924019ec/attachment.html>
More information about the Plasma-devel
mailing list