D13001: Handle children of added nodes as well
Kai Uwe Broulik
noreply at phabricator.kde.org
Mon May 21 12:48:33 UTC 2018
broulik added inline comments.
INLINE COMMENTS
> content-script.js:355
> mutation.addedNodes.forEach(function (node) {
> - if (node.tagName === "VIDEO" || node.tagName === "AUDIO") {
> - registerPlayer(node);
> - }
> + if (!node.querySelectorAll) return; // Ignore text
> + var players = node.querySelectorAll("video,audio");
`if (typeof node.querySelectorAll !== "function")`
also coding style, add braces
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D13001
To: fvogt, #plasma, broulik, davidedmundson
Cc: lbeltrame, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180521/1e03daac/attachment.html>
More information about the Plasma-devel
mailing list