D13013: Small fixes for execute_kwallet

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> pam_kwallet.c:392
>      if (drop_privileges(userInfo) < 0) {
>          syslog(LOG_ERR, "%s: could not set gid/uid/euid/egit for kwalletd", logPrefix);
>          goto cleanup;

fullSocket is not free'd.

> pam_kwallet.c:398
>      if ((envSocket = socket(AF_UNIX, SOCK_STREAM, 0)) == -1) {
> -        pam_syslog(pamh, LOG_ERR, "%s: couldn't create socket", logPrefix);
> -        return;
> +        syslog(LOG_ERR, "%s: couldn't create socket", logPrefix);
> +        goto cleanup;

Here also.

REPOSITORY
  R107 KWallet PAM Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13013

To: aacid, fvogt
Cc: anthonyfieroni, mgerstner, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180521/018d852e/attachment-0001.html>