D12974: Workspace KCM Code Improvement

Nathaniel Graham noreply at phabricator.kde.org
Sat May 19 14:45:19 UTC 2018


ngraham added a comment.


  In D12974#264991 <https://phabricator.kde.org/D12974#264991>, @furkantokac wrote:
  
  > In D12974#264920 <https://phabricator.kde.org/D12974#264920>, @ngraham wrote:
  >
  > > While we're doing some formatting and style cleanup work, how about renaming some variables? For example `m_ostateToolTip` and `m_ostateVisualFeedback` aren't very descriptive IMHO. Maybe instead, they could be `m_currentToolTipState` and `m_currentVisualFeedbackState`.
  >
  >
  > So they'll be changed as
  >  m_toolTipCurrentState m_toolTipOriginalState etc.
  
  
  Yep, sounds good!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12974

To: furkantokac, ngraham, romangg, #plasma
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180519/769b830a/attachment.html>


More information about the Plasma-devel mailing list