D12936: Rewrite workspace KCM in QtQuick

Furkan Tokac noreply at phabricator.kde.org
Fri May 18 15:38:27 UTC 2018


furkantokac added inline comments.

INLINE COMMENTS

> zzag wrote in workspaceoptions.cpp:110
> Coding style nitpick: No whitespace after `(` and before `)`. Also, I believe, there should be a whitespace between control statement keyword and opening parentheses.

Done. Thanks. I avoid small changes for better diff revision so now I'm reviewing the whole patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12936

To: furkantokac, romangg, ngraham, #plasma
Cc: ltoscano, yurchor, zzag, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180518/c3db9f7c/attachment.html>


More information about the Plasma-devel mailing list